rework time zone support to set DatabaseFeatures.supports_timezones = False #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
supports_timezones
branch
from
d083640 to
173c21e
Compare
Jibola
reviewed
Jun 5, 2024
Comment on lines
+218
to
+291
| "timezones.tests.NewDatabaseTests.test_cursor_execute_accepts_naive_datetime", | ||
| "timezones.tests.NewDatabaseTests.test_cursor_execute_returns_naive_datetime", |
There was a problem hiding this comment.
I'm not sure I understand why the new test we skip is the naive version. So we will no longer support naive datetime instead?
Or is it that the naive tests were the original ones that should have been failing?
There was a problem hiding this comment.
Which tests run is controlled by DatabaseFeatures.supports_timezones, i.e. some tests are decorated with @skipUnlessDBFeature("supports_timezones") or @skipIfDBFeature("supports_timezones").
These are the tests that run when supports_timezones = False but we can't run them on MongoDB because they use SQL.
Jibola
approved these changes
Jun 5, 2024
… False Previously, incorrect values were stored in the database.
timgraham
force-pushed
the
supports_timezones
branch
from
173c21e to
78fd337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, incorrect values were stored in the database.